refactor(audio): rename latency config fields for clarity

Update config field names to better reflect their specific usage contexts in adaptive buffer and optimizer components. This improves code maintainability by making the purpose of each latency target more explicit.
This commit is contained in:
Alex P 2025-09-05 12:27:35 +00:00
parent 463f34e40b
commit 1a0c7a84bc
3 changed files with 18 additions and 30 deletions

View File

@ -70,8 +70,8 @@ func DefaultAdaptiveBufferConfig() AdaptiveBufferConfig {
HighMemoryThreshold: GetConfig().HighMemoryThreshold * 100, // Above 75% memory usage (lowered for earlier response) HighMemoryThreshold: GetConfig().HighMemoryThreshold * 100, // Above 75% memory usage (lowered for earlier response)
// Latency targets // Latency targets
TargetLatency: GetConfig().TargetLatency, // Target 20ms latency TargetLatency: GetConfig().AdaptiveBufferTargetLatency, // Target 20ms latency
MaxLatency: GetConfig().MaxLatencyTarget, // Max acceptable latency MaxLatency: GetConfig().LatencyMonitorTarget, // Max acceptable latency
// Adaptation settings // Adaptation settings
AdaptationInterval: GetConfig().BufferUpdateInterval, // Check every 500ms AdaptationInterval: GetConfig().BufferUpdateInterval, // Check every 500ms

View File

@ -109,7 +109,7 @@ func (ao *AdaptiveOptimizer) handleLatencyOptimization(metrics LatencyMetrics) e
// calculateTargetOptimizationLevel determines the appropriate optimization level // calculateTargetOptimizationLevel determines the appropriate optimization level
func (ao *AdaptiveOptimizer) calculateTargetOptimizationLevel(metrics LatencyMetrics) int64 { func (ao *AdaptiveOptimizer) calculateTargetOptimizationLevel(metrics LatencyMetrics) int64 {
// Base calculation on current latency vs target // Base calculation on current latency vs target
latencyRatio := float64(metrics.Current) / float64(GetConfig().LatencyTarget) // 50ms target latencyRatio := float64(metrics.Current) / float64(GetConfig().AdaptiveOptimizerLatencyTarget) // 50ms target
// Adjust based on trend // Adjust based on trend
switch metrics.Trend { switch metrics.Trend {

View File

@ -716,14 +716,8 @@ type AudioConfigConstants struct {
// Default 10s provides good balance between stability and adaptability. // Default 10s provides good balance between stability and adaptability.
AdaptiveOptimizerStability time.Duration // 10s AdaptiveOptimizerStability time.Duration // 10s
// MaxLatencyTarget defines maximum acceptable latency target. // LatencyMonitorTarget defines target latency for latency monitoring system.
// Used in: latency_monitor.go for latency threshold monitoring // Used in: latency_monitor.go for latency optimization goals and threshold monitoring
// Impact: Lower values enforce stricter latency requirements.
// Default 50ms provides good real-time audio latency target.
MaxLatencyTarget time.Duration // 50ms
// LatencyMonitorTarget defines target latency for monitoring and optimization.
// Used in: latency_monitor.go for latency optimization goals
// Impact: Lower targets improve audio responsiveness but may increase system load. // Impact: Lower targets improve audio responsiveness but may increase system load.
// Default 50ms provides excellent real-time audio performance target. // Default 50ms provides excellent real-time audio performance target.
LatencyMonitorTarget time.Duration // 50ms LatencyMonitorTarget time.Duration // 50ms
@ -756,11 +750,11 @@ type AudioConfigConstants struct {
// Default 75% triggers aggressive memory conservation measures. // Default 75% triggers aggressive memory conservation measures.
HighMemoryThreshold float64 // 75% memory threshold HighMemoryThreshold float64 // 75% memory threshold
// TargetLatency defines target latency for adaptive buffer optimization. // AdaptiveBufferTargetLatency defines target latency for adaptive buffer optimization.
// Used in: adaptive_buffer.go for latency-based buffer sizing // Used in: adaptive_buffer.go for latency-based buffer sizing
// Impact: Lower targets reduce buffer sizes, higher targets increase stability. // Impact: Lower targets reduce buffer sizes, higher targets increase stability.
// Default 20ms provides excellent real-time performance target. // Default 20ms provides excellent real-time performance target for buffer management.
TargetLatency time.Duration // 20ms target latency AdaptiveBufferTargetLatency time.Duration // 20ms target latency
// Adaptive Optimizer Configuration - Settings for performance optimization // Adaptive Optimizer Configuration - Settings for performance optimization
// Used in: adaptive_optimizer.go for system performance optimization // Used in: adaptive_optimizer.go for system performance optimization
@ -778,11 +772,11 @@ type AudioConfigConstants struct {
// Default 300ms provides clear indication of optimization failure. // Default 300ms provides clear indication of optimization failure.
RollbackThreshold time.Duration // 300ms rollback threshold RollbackThreshold time.Duration // 300ms rollback threshold
// LatencyTarget defines target latency for optimization goals. // AdaptiveOptimizerLatencyTarget defines target latency for adaptive optimizer.
// Used in: adaptive_optimizer.go for optimization target setting // Used in: adaptive_optimizer.go for optimization target setting
// Impact: Lower targets improve responsiveness but may increase system load. // Impact: Lower targets improve responsiveness but may increase system load.
// Default 50ms provides good balance between performance and stability. // Default 50ms provides good balance between performance and stability.
LatencyTarget time.Duration // 50ms latency target AdaptiveOptimizerLatencyTarget time.Duration // 50ms latency target
// Latency Monitor Configuration - Settings for latency monitoring and analysis // Latency Monitor Configuration - Settings for latency monitoring and analysis
// Used in: latency_monitor.go for latency tracking and alerting // Used in: latency_monitor.go for latency tracking and alerting
@ -2010,12 +2004,6 @@ func DefaultAudioConfig() *AudioConfigConstants {
// Default 10s allows system to stabilize before making further adjustments // Default 10s allows system to stabilize before making further adjustments
AdaptiveOptimizerStability: 10 * time.Second, AdaptiveOptimizerStability: 10 * time.Second,
// MaxLatencyTarget defines maximum acceptable latency target (50ms).
// Used in: Latency monitoring, performance optimization, quality control
// Impact: Sets upper bound for acceptable audio latency
// Default 50ms represents maximum tolerable latency for real-time audio
MaxLatencyTarget: 50 * time.Millisecond,
// LatencyMonitorTarget defines target latency for monitoring (50ms). // LatencyMonitorTarget defines target latency for monitoring (50ms).
// Used in: Latency monitoring systems, performance alerts // Used in: Latency monitoring systems, performance alerts
// Impact: Controls when latency warnings and optimizations are triggered // Impact: Controls when latency warnings and optimizations are triggered
@ -2023,11 +2011,11 @@ func DefaultAudioConfig() *AudioConfigConstants {
LatencyMonitorTarget: 50 * time.Millisecond, LatencyMonitorTarget: 50 * time.Millisecond,
// Adaptive Buffer Configuration // Adaptive Buffer Configuration
LowCPUThreshold: 0.20, LowCPUThreshold: 0.20,
HighCPUThreshold: 0.60, HighCPUThreshold: 0.60,
LowMemoryThreshold: 0.50, LowMemoryThreshold: 0.50,
HighMemoryThreshold: 0.75, HighMemoryThreshold: 0.75,
TargetLatency: 20 * time.Millisecond, AdaptiveBufferTargetLatency: 20 * time.Millisecond,
// Adaptive Buffer Size Configuration // Adaptive Buffer Size Configuration
AdaptiveMinBufferSize: 3, // Minimum 3 frames for stability AdaptiveMinBufferSize: 3, // Minimum 3 frames for stability
@ -2035,9 +2023,9 @@ func DefaultAudioConfig() *AudioConfigConstants {
AdaptiveDefaultBufferSize: 6, // Default 6 frames for balanced performance AdaptiveDefaultBufferSize: 6, // Default 6 frames for balanced performance
// Adaptive Optimizer Configuration // Adaptive Optimizer Configuration
CooldownPeriod: 30 * time.Second, CooldownPeriod: 30 * time.Second,
RollbackThreshold: 300 * time.Millisecond, RollbackThreshold: 300 * time.Millisecond,
LatencyTarget: 50 * time.Millisecond, AdaptiveOptimizerLatencyTarget: 50 * time.Millisecond,
// Latency Monitor Configuration // Latency Monitor Configuration
MaxLatencyThreshold: 200 * time.Millisecond, MaxLatencyThreshold: 200 * time.Millisecond,