Files
hackerspace.sh/app/(app)/members/page.tsx
T
Moheeb ZaraandClaude Opus 4.8 70b85a20fa fix(members): repair broken member-directory visibility gate
member_directory_visibility is the directory_visibility enum
(board_only|member_count_visible|members_visible|public_members_visible), but
the gate compared against 'board_visible'/'admin_only' — values from other
enums that never match — so every setting except members_visible silently
restricted the directory, including public_members_visible (meant to be the
most open). Map the gate to the real enum values.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
2026-08-01 21:19:29 -07:00

130 lines
5.3 KiB
TypeScript

import { createClient } from '@/lib/supabase/server'
import { PageHeader, PageTitle } from '@/components/ui/page-title'
import { hasPermission } from '@/lib/permissions-cache'
import { MembersClient } from './members-client'
import { InvitesPanel } from '../customize/panels/invites-panel'
// member_directory_visibility values come from space settings:
// admin_only — only admins see the directory
// board_visible — admins + board + treasurer see the directory
// members_visible — every member of the space sees the directory (default)
const ELEVATED_ROLES = new Set(['admin', 'board', 'treasurer'])
export default async function MembersPage() {
const supabase = await createClient()
const { data: { user } } = await supabase.auth.getUser()
if (!user) return null
const { data: self } = await supabase
.from('space_members')
.select('space_id, role, spaces(slug)')
.eq('user_id', user.id)
.in('status', ['current', 'unverified', 'late'])
.single()
if (!self) return null
const { data: space } = await supabase
.from('spaces')
.select('member_directory_visibility')
.eq('id', self.space_id)
.single()
const visibility = space?.member_directory_visibility ?? 'members_visible'
const isAdmin = self.role === 'admin'
const isElevated = ELEVATED_ROLES.has(self.role)
// member_directory_visibility is the `directory_visibility` enum. The gate
// previously compared against 'board_visible'/'admin_only' — values from
// OTHER enums that never match — so every setting except 'members_visible'
// silently restricted the directory (including 'public_members_visible',
// which should be the most open). Map to the real enum values:
// - members_visible / public_members_visible: any authenticated member
// - board_only / member_count_visible: only elevated roles see the full list
const allowed =
visibility === 'members_visible' ||
visibility === 'public_members_visible' ||
((visibility === 'board_only' || visibility === 'member_count_visible') && isElevated)
if (!allowed) {
return (
<div>
<PageHeader>
<PageTitle>Members</PageTitle>
</PageHeader>
<div className="p-8 max-w-2xl">
<div className="bg-card border border-border rounded p-6">
<p className="font-sans text-sm text-foreground mb-2">The member directory is restricted in this space.</p>
<p className="font-sans text-sm text-muted-foreground">
A space admin has set member directory visibility to <code className="font-mono text-xs px-1 py-0.5 bg-muted rounded">{visibility}</code>.
Contact an admin if you need access.
</p>
</div>
</div>
</div>
)
}
const { data: members } = await supabase
.from('space_members')
.select('*')
.eq('space_id', self.space_id)
.order('joined_at')
// Area-lead roles, so admin/board can assign a lead straight from a member
// row (the same capability also lives in Customize -> Area leads).
const canManageLeads = self.role === 'admin' || self.role === 'board'
const { data: areaLeadRoles } = canManageLeads
? await supabase
.from('area_leads')
.select('id, area_name, lead_id')
.eq('space_id', self.space_id)
.order('area_name')
: { data: [] }
// Admin/board can create and share join links straight from this page (the
// same InvitesPanel used in Customize). This is where the first-run
// "Invite or add members" step sends people, so the UI has to be here.
const canInvite = self.role === 'admin' || self.role === 'board'
const spaceSlug = (self.spaces as { slug?: string } | null)?.slug ?? ''
const { data: invites } = canInvite
? await supabase
.from('space_invites')
.select('id, code, label, expires_at, max_uses, uses_count, is_enabled, role, created_at')
.eq('space_id', self.space_id)
.order('created_at', { ascending: false })
: { data: [] }
// certifications.grant (the Instructor capability) is independent of
// admin/board, so check it explicitly to decide whether to show the
// per-member certifications panel.
// Request-cached: door.manage / forms.manage here dedupe with the layout's
// nav-permission resolution for the same render.
const [canGrantCerts, canManageCards, canViewForms] = await Promise.all([
hasPermission(user.id, self.space_id, 'certifications.grant'),
hasPermission(user.id, self.space_id, 'door.manage'),
hasPermission(user.id, self.space_id, 'forms.manage'),
])
return (
<MembersClient
members={members ?? []}
currentRole={self.role}
canGrantCerts={!!canGrantCerts}
canManageCards={!!canManageCards}
canViewForms={!!canViewForms}
areaLeadRoles={(areaLeadRoles ?? []) as Array<{ id: string; area_name: string; lead_id: string | null }>}
inviteSlot={
canInvite ? (
<InvitesPanel
isAdmin={isAdmin}
creatorRole={self.role}
spaceSlug={spaceSlug}
invites={(invites ?? []) as Array<{ id: string; code: string; label: string | null; expires_at: string | null; max_uses: number | null; uses_count: number; is_enabled: boolean; role: string; created_at: string }>}
/>
) : undefined
}
/>
)
}