Files
Moheeb ZaraandClaude Opus 4.8 b1edb5c460 types: clear remaining tsc errors across 41 files (76→14, behavior-preserving)
Per-file type-only fixes surfaced after the Supabase client was correctly
typed. All fixes preserve runtime behavior; no any/ts-ignore/ts-expect-error.

- lib/supabase/client.ts: annotate the browser client as SupabaseClient<Database>
  (same ssr/js drift as server.ts; fixes it centrally for all callers).
- Supabase embedded-select joins whose FK metadata is missing from the
  generated types are bridged with `as unknown as <target>` + a TODO to remove
  after regenerating types/database.ts.
- setState optimistic-update variance and raw <select> enum values cast to the
  precise element/union type; .insert payload fields (Json, enums) given the
  precise column type via satisfies/field casts.
- Added narrowing guards where a value was legitimately nullable (comms channel,
  public form page) without changing the intended path.

The 14 remaining errors are confined to the four files fixed in Phase B (real
bugs + the tautological actions.test rewrite). 639 tests still green.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
2026-08-01 18:56:11 -07:00

189 lines
6.3 KiB
TypeScript

'use server'
import { revalidatePath } from 'next/cache'
import { createClient } from '@/lib/supabase/server'
import type { TablesInsert } from '@/types/database'
import { requireMember, requireMemberWithRole, parseInput } from '@/lib/auth-helpers'
import { ADMIN_ROLES } from '@/lib/permissions'
import { createSecretSchema, updateSecretSchema, uuidSchema } from '@/lib/validations'
import { encryptSecret, decryptSecret, encryptionAvailable } from '@/lib/secrets/crypto'
const SECRETS_RW_ROLES = ['admin', 'board'] as const
export async function createSecret(formData: {
title: string
value: string
description?: string
area?: string
icon?: string
}) {
const v = parseInput(createSecretSchema, formData)
if (!v.ok) return { error: v.error }
const supabase = await createClient()
const auth = await requireMemberWithRole(supabase, ADMIN_ROLES, 'Admin access required')
if (!auth.ok) return { error: auth.error }
const { member } = auth
const row: Record<string, unknown> = {
space_id: member.space_id,
title: v.data.title,
label: v.data.title,
description: v.data.description ?? null,
area: v.data.area ?? null,
icon: v.data.icon ?? null,
}
if (encryptionAvailable()) {
const { ciphertext, version } = encryptSecret(v.data.value)
row.encrypted_value = ciphertext
row.encryption_version = version
row.value = ''
} else {
row.value = v.data.value
row.encryption_version = 0
}
const { data, error } = await supabase
.from('secrets')
.insert(row as TablesInsert<'secrets'>)
.select('id, title, label, area, description, icon, encryption_version, created_at, updated_at, space_id, created_by')
.single()
if (error) return { error: error.message }
revalidatePath('/ops')
return { data }
}
export async function updateSecret(secretId: string, updates: {
title?: string
value?: string
description?: string | null
area?: string | null
icon?: string | null
}) {
const idCheck = parseInput(uuidSchema, secretId)
if (!idCheck.ok) return { error: 'Invalid secret ID' }
const v = parseInput(updateSecretSchema, updates)
if (!v.ok) return { error: v.error }
const supabase = await createClient()
const auth = await requireMemberWithRole(supabase, SECRETS_RW_ROLES, 'Board or admin access required')
if (!auth.ok) return { error: auth.error }
const { member } = auth
const patch: Record<string, unknown> = {}
if (v.data.title !== undefined) {
patch.title = v.data.title
patch.label = v.data.title
}
if (v.data.description !== undefined) patch.description = v.data.description
if (v.data.area !== undefined) patch.area = v.data.area
if (v.data.icon !== undefined) patch.icon = v.data.icon
if (v.data.value !== undefined) {
if (encryptionAvailable()) {
const { ciphertext, version } = encryptSecret(v.data.value)
patch.encrypted_value = ciphertext
patch.encryption_version = version
patch.value = ''
} else {
patch.value = v.data.value
patch.encryption_version = 0
}
}
const { error } = await supabase
.from('secrets')
.update(patch)
.eq('id', idCheck.data)
.eq('space_id', member.space_id)
if (error) return { error: error.message }
revalidatePath('/ops')
return { success: true as const }
}
// Reveal returns the plaintext for a single secret. The list endpoint must
// NEVER send the plaintext or ciphertext to the client; only this action does,
// and only when the caller is board/admin in the owning space.
export async function revealSecret(secretId: string) {
const idCheck = parseInput(uuidSchema, secretId)
if (!idCheck.ok) return { error: 'Invalid secret ID' }
const supabase = await createClient()
// RLS (secrets_select) is the authority: admin/board, OR the
// ops.secrets.read role permission, OR a per-secret ops_acl entry. We no
// longer pre-block on built-in role here, because that ignored both the
// permission and the ACL path. A denied row simply does not come back.
const auth = await requireMember(supabase)
if (!auth.ok) return { error: auth.error }
const { member } = auth
const { data: { user } } = await supabase.auth.getUser()
const { data, error } = await supabase
.from('secrets')
.select('id, encryption_version, encrypted_value, value, title')
.eq('id', idCheck.data)
.eq('space_id', member.space_id)
.maybeSingle()
if (error) return { error: error.message }
if (!data) return { error: 'You do not have access to this secret.' }
// A row marked encrypted (version > 0) MUST have ciphertext. If it does
// not, the row is corrupt: do not silently fall back to the (empty/stale)
// plaintext column, which would either leak nothing useful or mask data
// loss. Surface it instead.
if ((data.encryption_version ?? 0) > 0 && !data.encrypted_value) {
return { error: 'This secret is marked encrypted but has no ciphertext. It may be corrupted; re-enter it.' }
}
let plaintext: string
try {
if (data.encryption_version === 1 && data.encrypted_value) {
const raw = data.encrypted_value as unknown
const buf = typeof raw === 'string'
? Buffer.from((raw as string).replace(/^\\x/, ''), 'hex')
: Buffer.from(raw as Uint8Array)
plaintext = decryptSecret(buf, 1)
} else {
plaintext = (data.value ?? '') as string
}
} catch (e) {
return { error: e instanceof Error ? e.message : 'Decryption failed' }
}
if (user?.id) {
await supabase.from('activity_log').insert({
space_id: member.space_id,
user_id: user.id,
action: 'secret.revealed',
entity_type: 'secret',
entity_id: data.id,
details: `Revealed secret "${data.title}"`,
})
}
return { value: plaintext }
}
export async function deleteSecret(secretId: string) {
const v = parseInput(uuidSchema, secretId)
if (!v.ok) return { error: 'Invalid secret ID' }
const supabase = await createClient()
const auth = await requireMemberWithRole(supabase, ['admin'], 'Admin access required')
if (!auth.ok) return { error: auth.error }
const { member } = auth
const { error } = await supabase
.from('secrets')
.delete()
.eq('id', v.data)
.eq('space_id', member.space_id)
if (error) return { error: error.message }
revalidatePath('/ops')
return { success: true as const }
}