Superminaren
/
MMDVM
mirror of https://github.com/g4klx/MMDVM.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix RX interrupt flag being cleared on the wrong USART in STMUART. 

handleIRQ() hardcoded USART1 when clearing the RXNE pending bit, so on
boards where the repeater/display UART is not USART1 (Nucleo, Discovery,
F767, UART5-based boards) the flag was cleared on the wrong peripheral.
Use the m_usart member, matching the TXE handling below.

Also fix flush(): it passed a flag constant to USART_GetITStatus and
span while TXE was set, which returns immediately since TXE indicates
the data register is already empty. Wait for the software TX FIFO to
drain and then for the TC flag, which indicates the shift register has
actually emptied.
This commit is contained in:
Clint Chance 2026-07-12 16:42:47 -05:00
parent 57e692ad8c
commit a1794b44ed
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
STMUART.cpp
View File

@ -61,7 +61,7 @@ void CSTMUART::handleIRQ()
if (USART_GetITStatus(m_usart, USART_IT_RXNE)) { if (USART_GetITStatus(m_usart, USART_IT_RXNE)) {
if(!m_rxFifo.isFull()) if(!m_rxFifo.isFull())
m_rxFifo.put((uint8_t) USART_ReceiveData(m_usart)); m_rxFifo.put((uint8_t) USART_ReceiveData(m_usart));
USART_ClearITPendingBit(USART1, USART_IT_RXNE); USART_ClearITPendingBit(m_usart, USART_IT_RXNE);
} }
if (USART_GetITStatus(m_usart, USART_IT_TXE)) { if (USART_GetITStatus(m_usart, USART_IT_TXE)) {
@ -82,8 +82,12 @@ void CSTMUART::flush()
if(m_usart == NULL) if(m_usart == NULL)
return; return;
// wait until the TXE shows the shift register is empty // wait until the TX FIFO has drained
while (USART_GetITStatus(m_usart, USART_FLAG_TXE)) while (!m_txFifo.isEmpty())
;
// wait until the TC flag shows the shift register is empty
while (USART_GetFlagStatus(m_usart, USART_FLAG_TC) == RESET)
; ;
} }