mirror of https://github.com/google/pebble
106 lines
2.7 KiB
PHP
106 lines
2.7 KiB
PHP
<?php
|
|
// Copyright 2024 Google LLC
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
|
|
/**
|
|
* Uses Google's `cpplint.py` to check code.
|
|
*/
|
|
final class PebbleCpplintLinter extends ArcanistExternalLinter {
|
|
|
|
public function getLinterName() {
|
|
return 'cpplint-pebble';
|
|
}
|
|
|
|
public function getLinterConfigurationName() {
|
|
return 'cpplint-pebble';
|
|
}
|
|
|
|
public function getDefaultBinary() {
|
|
return "tools/arc/linting/linters/cpplint/cpplint.py";
|
|
}
|
|
|
|
public function getInstallInstructions() {
|
|
return pht('Ask Tyler Hoffman to fix it.');
|
|
}
|
|
|
|
public function shouldExpectCommandErrors() {
|
|
return true;
|
|
}
|
|
|
|
public function supportsReadDataFromStdin() {
|
|
return true;
|
|
}
|
|
|
|
public function getReadDataFromStdinFilename() {
|
|
return '-';
|
|
}
|
|
|
|
protected function getDefaultFlags() {
|
|
return array();
|
|
}
|
|
|
|
protected function getDefaultMessageSeverity($code) {
|
|
return ArcanistLintSeverity::SEVERITY_WARNING;
|
|
}
|
|
|
|
protected function parseLinterOutput($path, $err, $stdout, $stderr) {
|
|
$lines = explode("\n", $stderr);
|
|
|
|
$messages = array();
|
|
foreach ($lines as $line) {
|
|
$line = trim($line);
|
|
$matches = null;
|
|
$regex = '/(\d+):\s*(.*)\s*\[(.*)\] \[(\d+)\]$/';
|
|
if (!preg_match($regex, $line, $matches)) {
|
|
continue;
|
|
}
|
|
foreach ($matches as $key => $match) {
|
|
$matches[$key] = trim($match);
|
|
}
|
|
|
|
$message = new ArcanistLintMessage();
|
|
$message->setPath($path);
|
|
$message->setLine($matches[1]);
|
|
$message->setCode($matches[3]);
|
|
$message->setName($matches[3]);
|
|
$message->setDescription($matches[2]);
|
|
$message->setSeverity($this->getLintMessageSeverity($matches[3]));
|
|
|
|
$messages[] = $message;
|
|
}
|
|
|
|
if ($err && !$messages) {
|
|
return false;
|
|
}
|
|
|
|
return $messages;
|
|
}
|
|
|
|
protected function getLintCodeFromLinterConfigurationKey($code) {
|
|
if (!preg_match('@^[a-z_]+/[a-z_]+$@', $code)) {
|
|
throw new Exception(
|
|
pht(
|
|
'Unrecognized lint message code "%s". Expected a valid cpplint '.
|
|
'lint code like "%s" or "%s".',
|
|
$code,
|
|
'build/include_order',
|
|
'whitespace/braces'));
|
|
}
|
|
|
|
return $code;
|
|
}
|
|
|
|
}
|