danielhanchen
d4a943f9a5
qwen4exp: tidy comments and simplify image token read
...
Rewrite the comments this series adds to the AGENTS.md rules: one or two lines,
no prose hard-wrapped mid-sentence, no narrative or history, and no comment that
only restates the code. Net 146 fewer comment lines, no code change.
Correct the PLE image comment: mtmd does not consume the placeholder ids. An
image is decoded as an embeddings-only batch, so ubatch->token is null and the
per-position ids never exist here. gemma3n and gemma4 hit the same case and
stand in row 0 of per_layer_token_embd; qwen4exp stands in the configured image
token id instead.
Read image_token_id straight from self.hparams in the converter. base.py merges
text_config into the root of hparams, and the key sits at the root of
config.json, so the config.json re-read was redundant.
(cherry picked from commit 205840c12169057da3e8d2f65ec4ceec3e18b980)
2026-08-27 00:45:01 +00:00
..
2026-08-26 13:40:35 +00:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-22 10:35:50 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-24 13:21:00 +03:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-19 16:53:31 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-06-07 21:41:39 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-26 12:05:31 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-05-15 15:18:12 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-27 00:45:01 +00:00
2026-08-22 12:19:48 +03:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00
2026-08-17 10:15:11 +02:00