mirror of https://github.com/jetkvm/kvm.git
64a6a1a078
This commit addresses three critical issues discovered during testing: Issue 1 - Intermittent mouse control loss requiring page refresh: When a session was promoted to primary, the HID queue handlers were fetching a fresh session copy from the session manager instead of using the original session pointer. This meant the queue handler had a stale Mode field (observer) while the manager had the updated Mode (primary). The permission check would fail, silently dropping all mouse input until the page was refreshed. Issue 2 - Missing permission failure diagnostics: When keyboard/mouse input was blocked due to insufficient permissions, there was no debug logging to help diagnose why input wasn't working. This made troubleshooting observer mode issues extremely difficult. Issue 3 - Session timeout despite active jiggler: The server-side jiggler moves the mouse every 30s after inactivity to prevent screen savers, but wasn't updating the session's LastActive timestamp. This caused sessions to timeout after 60s even with the jiggler active. Issue 4 - Session flapping after emergency promotion: When a session timed out and another was promoted, the newly promoted session had a stale LastActive timestamp (60+ seconds old), causing immediate re-timeout. This created an infinite loop where both sessions rapidly alternated between primary and observer every second. Issue 5 - Unnecessary WebSocket reconnections: The WebSocket fallback was unconditionally closing and reconnecting during emergency promotions, even when the connection was healthy. This caused spurious "Connection Issue Detected" overlays during normal promotions. Changes: - webrtc.go: Use original session pointer in handleQueues() (line 197) - hidrpc.go: Add debug logging when permission checks block input (lines 31-34, 61-64, 75-78) - jiggler.go: Update primary session LastActive after mouse movement (lines 146-152) - session_manager.go: Reset LastActive to time.Now() on promotion (line 1090) - devices.$id.tsx: Only reconnect if connection is unhealthy (lines 413-425) This ensures: 1. Queue handlers always have up-to-date session state 2. Permission failures are visible in logs for debugging 3. Jiggler prevents both screen savers AND session timeout 4. Newly promoted sessions get full timeout period (no immediate re-timeout) 5. Emergency promotions only reconnect when connection is actually stale 6. No spurious "Connection Issue" overlays during normal promotions |
||
|---|---|---|
| .. | ||
| public | ||
| src | ||
| .env.cloud-development | ||
| .env.cloud-production | ||
| .env.cloud-staging | ||
| .gitignore | ||
| .prettierrc | ||
| dev_device.sh | ||
| eslint.config.cjs | ||
| index.html | ||
| package-lock.json | ||
| package.json | ||
| postcss.config.js | ||
| tailwind.config.js | ||
| tsconfig.json | ||
| tsconfig.node.json | ||
| vite-env.d.ts | ||
| vite.config.ts | ||