Merge f23480792b into 6e1b84f39b

ui/src/hooks/stores.ts

@@ -603,9 +603,6 @@ export interface UpdateState {
 
   updateErrorMessage: string | null;
   setUpdateErrorMessage: (errorMessage: string) => void;
-
-  shouldReload: boolean;
-  setShouldReload: (reloadRequired: boolean) => void;
 }
 
 export const useUpdateStore = create<UpdateState>(set => ({
@@ -643,9 +640,6 @@ export const useUpdateStore = create<UpdateState>(set => ({
   updateErrorMessage: null,
   setUpdateErrorMessage: (errorMessage: string) =>
     set({ updateErrorMessage: errorMessage }),
-
-  shouldReload: false,
-  setShouldReload: (reloadRequired: boolean) => set({ shouldReload: reloadRequired }),
 }));
 
 export type UsbConfigModalViews = "updateUsbConfig" | "updateUsbConfigSuccess";
@@ -856,12 +850,12 @@ export interface MacrosState {
   loadMacros: () => Promise<void>;
   saveMacros: (macros: KeySequence[]) => Promise<void>;
   sendFn:
-  | ((
+    | ((
-    method: string,
+        method: string,
-    params: unknown,
+        params: unknown,
-    callback?: ((resp: JsonRpcResponse) => void) | undefined,
+        callback?: ((resp: JsonRpcResponse) => void) | undefined,
-  ) => void)
+      ) => void)
-  | null;
+    | null;
   setSendFn: (
     sendFn: (
       method: string,

ui/src/routes/devices.$id.settings.general.update.tsx

@@ -18,24 +18,20 @@ export default function SettingsGeneralUpdateRoute() {
   const location = useLocation();
   const { updateSuccess } = location.state || {};
 
-  const { setModalView, otaState, shouldReload, setShouldReload } = useUpdateStore();
+  const { setModalView, otaState } = useUpdateStore();
   const { send } = useJsonRpc();
 
   const onClose = useCallback(async () => {
     navigate(".."); // back to the devices.$id.settings page
-
+    // Add 1s delay between navigation and calling reload() to prevent reload from interrupting the navigation.
-    if (shouldReload) {
+    await sleep(1000);
-      setShouldReload(false);
+    window.location.reload(); // force a full reload to ensure the current device/cloud UI version is loaded
-      await sleep(1000);      // Add 1s delay between navigation and calling reload() to prevent reload from interrupting the navigation.
+  }, [navigate]);
-      window.location.reload(); // force a full reload to ensure the current device/cloud UI version is loaded
-    }
-  }, [navigate, setShouldReload, shouldReload]);
 
   const onConfirmUpdate = useCallback(() => {
-    setShouldReload(true);
     send("tryUpdate", {});
     setModalView("updating");
-  }, [send, setModalView, setShouldReload]);
+  }, [send, setModalView]);
 
   useEffect(() => {
     if (otaState.updating) {
@@ -137,7 +133,6 @@ function LoadingState({
   const { setModalView } = useUpdateStore();
 
   const progressBarRef = useRef<HTMLDivElement>(null);
-
   useEffect(() => {
     abortControllerRef.current = new AbortController();
     const signal = abortControllerRef.current.signal;