f7a5ed6d2e
fix: only auto-remove disconnected pending sessions
2025-10-23 20:56:15 +03:00
15963d39ef
fix: primary session timeout promoting wrong session
...
When primary timed out, emergency promotion was re-promoting the same
timed-out session instead of promoting an observer. The emergency bypass
logic ignored the excludeSessionID parameter.
Fixed by applying session exclusion logic in all emergency promotion paths.
2025-10-23 14:19:46 +03:00
ba2fa34385
fix: address critical issues in multi-session management
...
- Fix nickname index stale pointer during session reconnection
- Reset LastActive for all emergency promotions to prevent cascade timeouts
- Bypass rate limits when no primary exists to prevent system deadlock
- Replace manual mutex with atomic.Int32 for session counter (fixes race condition)
- Implement collect-then-delete pattern for safe map iteration
- Reduce logging verbosity for routine cleanup operations
2025-10-17 23:27:27 +03:00
40ccecc902
fix: address critical race conditions and security issues in multi-session
...
This commit resolves multiple critical issues in the multi-session implementation:
Race Conditions Fixed:
- Add primaryPromotionLock mutex to prevent dual-primary corruption
- Implement atomic nickname reservation before session addition
- Add corruption detection and auto-fix in transferPrimaryRole
- Implement broadcast coalescing to prevent storms
Security Improvements:
- Add permission check for HID RPC handshake
- Implement sliding window rate limiting for emergency promotions
- Add global RPC rate limiter (2000 req/sec across all sessions)
- Enhance nickname validation (control chars, zero-width chars, unicode)
Reliability Enhancements:
- Add 5-second timeouts to all WebSocket writes
- Add RPC queue monitoring (warns at 200+ messages)
- Verify grace period memory leak protection
- Verify goroutine cleanup on session removal
Technical Details:
- Use double-locking pattern (primaryPromotionLock → mu)
- Implement deferred cleanup for failed nickname reservations
- Use atomic.Bool for broadcast coalescing
- Add trust scoring for emergency promotion selection
Files Modified:
- session_manager.go: Core session management fixes
- session_cleanup_handlers.go: Rate limiting for emergency promotions
- hidrpc.go: Permission checks for handshake
- jsonrpc_session_handlers.go: Enhanced nickname validation
- jsonrpc.go: Global RPC rate limiting
- webrtc.go: WebSocket timeouts and queue monitoring
Total: 266 insertions, 73 deletions across 6 files
2025-10-17 14:28:16 +03:00
846caf77ce
refactor: improve code maintainability with focused handler functions
...
Extract large switch statements and functions into focused, reusable handlers
to improve code maintainability while preserving 100% functionality.
Changes:
- Extract onRPCMessage switch (200+ lines → 20 lines) into jsonrpc_session_handlers.go
- Extract cleanupInactiveSessions (343 lines → 54 lines) into session_cleanup_handlers.go
- Consolidate duplicate emergency promotion logic into attemptEmergencyPromotion()
- Simplify shouldBecomePrimary boolean logic with self-documenting variables
All changes pass linting (0 issues) and maintain complete functionality.
2025-10-17 11:29:04 +03:00
Alex P