Superminaren
/
kvm
mirror of https://github.com/jetkvm/kvm.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix Various Absolute Mouse Coordinate Conversion Issues 

This change fixes various absolute mouse coordinate conversion issues. It fixes 1) the video clamping range which instead of from 0 to effectiveWidth (or effectiveHeight) should instead be from 0 to effectiveWidth - 1 (or effectiveHeight - 1), 2) the mouse coordinate size which instead of 32767 should instead be 32768 since the min value is 0x0000 and the max value is 0x7FFF (32767), and 3) a rounding operation which should instead of a truncation operation.
This commit is contained in:
rmschooley 2025-05-25 20:49:55 -05:00 committed by GitHub
parent 1f7c5c94d8
commit 1f47273468
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ui/src/components/WebRTCVideo.tsx
View File

@ -229,16 +229,16 @@ export default function WebRTCVideo() {
} }
// Clamp mouse position within the effective video boundaries // Clamp mouse position within the effective video boundaries
const clampedX = Math.min(Math.max(offsetX, e.offsetX), offsetX + effectiveWidth); const clampedX = Math.min(Math.max(offsetX, e.offsetX), offsetX + effectiveWidth - 1);
const clampedY = Math.min(Math.max(offsetY, e.offsetY), offsetY + effectiveHeight); const clampedY = Math.min(Math.max(offsetY, e.offsetY), offsetY + effectiveHeight - 1);
// Map clamped mouse position to the video stream's coordinate system // Map clamped mouse position to the video stream's coordinate system
const relativeX = (clampedX - offsetX) / effectiveWidth; const relativeX = (clampedX - offsetX) / effectiveWidth;
const relativeY = (clampedY - offsetY) / effectiveHeight; const relativeY = (clampedY - offsetY) / effectiveHeight;
// Convert to HID absolute coordinate system (0-32767 range) // Convert to HID absolute coordinate system (0-32767 range)
const x = Math.round(relativeX * 32767); const x = Math.trunc(relativeX * 32768);
const y = Math.round(relativeY * 32767); const y = Math.trunc(relativeY * 32768);
// Send mouse movement // Send mouse movement
const { buttons } = e; const { buttons } = e;