Files
hackerspace.sh/lib/actions/payments.ts
T
Moheeb Zara 86d44f6efc feat: import row validation + KB/process per-item ACLs
Continuing the audit backlog and finishing the permissions UI.

Import validation (recurring audit finding):
- Added importMembersSchema / importPaymentsCsvSchema. importMembers
  and importPaymentsCsv now validate per row (a single bad row no
  longer rejects the whole file), lowercase emails, normalize dates
  through flexibleDateTime(), enforce tier/platform enums and
  positive finite amounts, and return a `skipped` count instead of
  silently dropping invalid rows.

Permissions UI completion:
- OpsAclEditor is now wired into the KB/process viewer modal
  (admin/board), with entity type derived from the `process` tag.
  Per-item Ops access control now covers secrets + KB + processes,
  matching "all ops facilities stuff".

Left as-is with rationale in HANDOFF: /ops + /import denial paths
(unreachable behind the layout gate or already a clear non-leaking
denial); members-row make-area-lead shortcut (Customize -> Area
leads fully covers assignment); types/database.ts + docs regen
(pure hygiene, zero runtime/security impact, still tracked).

271/271 tests pass. Build clean. No migration this pass.
2026-05-15 18:33:53 -07:00

159 lines
4.5 KiB
TypeScript

'use server'
import { revalidatePath } from 'next/cache'
import { createClient } from '@/lib/supabase/server'
import {
requireMemberWithRole,
logActivity,
parseInput,
} from '@/lib/auth-helpers'
import { TREASURER_ROLES } from '@/lib/permissions'
import {
logCashPaymentSchema,
linkPaymentSchema,
importPaymentsCsvSchema,
} from '@/lib/validations'
import type { Enums } from '@/types/database'
type PaymentPlatform = Enums<'payment_platform'>
export async function logCashPayment(formData: {
amount: number
from_note: string
member_id?: string
transaction_date?: string
}) {
const v = parseInput(logCashPaymentSchema, formData)
if (!v.ok) return { error: v.error }
const supabase = await createClient()
const auth = await requireMemberWithRole(supabase, TREASURER_ROLES, 'Treasurer access required')
if (!auth.ok) return { error: auth.error }
const { member } = auth
const transactionDate = v.data.transaction_date ?? new Date().toISOString()
const { data, error } = await supabase
.from('payments')
.insert({
space_id: member.space_id,
platform: 'cash',
amount: v.data.amount,
from_identifier: 'Cash',
from_note: v.data.from_note,
member_id: v.data.member_id ?? null,
link_status: v.data.member_id ? 'linked' : 'unlinked',
transaction_date: transactionDate,
})
.select()
.single()
if (error) return { error: error.message }
if (v.data.member_id) {
await supabase
.from('space_members')
.update({
last_paid_at: transactionDate,
payment_status: 'current',
})
.eq('id', v.data.member_id)
.eq('space_id', member.space_id)
}
await logActivity(
supabase,
member,
'logged',
'payment',
data.id,
`$${v.data.amount} cash, ${v.data.from_note}`,
)
revalidatePath('/payments')
revalidatePath('/dashboard')
return { data }
}
export async function linkPaymentToMember(paymentId: string, memberId: string) {
const v = parseInput(linkPaymentSchema, { paymentId, memberId })
if (!v.ok) return { error: v.error }
const supabase = await createClient()
const auth = await requireMemberWithRole(supabase, TREASURER_ROLES, 'Treasurer access required')
if (!auth.ok) return { error: auth.error }
const { member: self } = auth
const { data: payment } = await supabase
.from('payments')
.select('amount, transaction_date')
.eq('id', v.data.paymentId)
.single()
const { error } = await supabase
.from('payments')
.update({ member_id: v.data.memberId, link_status: 'linked' })
.eq('id', v.data.paymentId)
.eq('space_id', self.space_id)
if (error) return { error: error.message }
if (payment) {
await supabase
.from('space_members')
.update({
last_paid_at: payment.transaction_date,
payment_status: 'current',
})
.eq('id', v.data.memberId)
.eq('space_id', self.space_id)
}
revalidatePath('/payments')
revalidatePath('/members')
revalidatePath('/dashboard')
return { success: true as const }
}
export async function importPaymentsCsv(rows: unknown) {
if (!Array.isArray(rows) || rows.length === 0) {
return { error: 'No rows to import' }
}
const supabase = await createClient()
const auth = await requireMemberWithRole(supabase, TREASURER_ROLES, 'Treasurer access required')
if (!auth.ok) return { error: auth.error }
const { member } = auth
// Per-row validation: platform enum, positive finite amount, normalized
// transaction_date. Invalid rows are skipped and counted, not silently
// dropped without feedback.
const rowSchema = importPaymentsCsvSchema.element
const inserts: Array<Record<string, unknown>> = []
let skipped = 0
for (const raw of rows) {
const r = rowSchema.safeParse(raw)
if (!r.success) { skipped++; continue }
inserts.push({
space_id: member.space_id,
platform: r.data.platform as PaymentPlatform,
amount: r.data.amount,
from_identifier: r.data.from_identifier,
from_note: r.data.from_note ?? null,
link_status: 'unlinked' as const,
transaction_date: r.data.transaction_date ?? new Date().toISOString(),
})
}
if (inserts.length === 0) {
return { error: `No valid rows to import (${skipped} skipped: bad platform, amount, or date).` }
}
const { data, error } = await supabase.from('payments').insert(inserts).select()
if (error) return { error: error.message }
revalidatePath('/payments')
revalidatePath('/dashboard')
return { data, count: data.length, skipped }
}