Files
hackerspace.sh/lib/actions/forum.ts
T
Moheeb Zara f5d670477b fix(security): close member self-escalation + harden after full audit
Full-application audit (5 parallel read-only audits). Two agent
"blockers" were false alarms and verified as already-correct. Real
findings fixed:

- Self-escalation (BLOCKER): migration 024 + schema.sql section 16
  extend prevent_member_self_role_change to also block a
  non-privileged member changing their own tier_id (self tier
  upgrade) and onboarding_completed_at (skipping required
  code-of-conduct via a raw PostgREST call). finishOnboarding and
  skipOnboarding now set onboarding_completed_at through the service
  client AFTER their server-side required-steps check, so the
  legitimate path is unaffected.
- Cross-tenant write scoping: added .eq('space_id', member.space_id)
  to updateForumThread, deleteForumThread, editComment, deleteComment,
  deleteChannel, renameChannel (RLS-only -> defence-in-depth).
- generateInviteCode: crypto.getRandomValues, widened to 8 chars
  (was Math.random, ~21 bits, enumerable under the join rate limit).
- SafeMarkdown: dropped iframe and the global style attribute
  (no unsandboxed embeds / UI-redress); markdown + safe HTML stay.
- /settings: server-side admin redirect before fetching space and
  integration config (was client-hidden only).
- app/(app)/layout.tsx: export const dynamic = 'force-dynamic'.
- Bounded queries: loadComments .limit(500), tasks .limit(2000).

Backlog from the audit is tracked in HANDOFF (import Zod schemas,
types/database.ts + docs regen, email lowercasing, unauthorized-
handling consistency, KB-modal ACL hookup).

271/271 tests pass. Build clean. Migrations 023 + 024 idempotent,
apply via deploy.sh on next deploy.
2026-05-15 17:35:11 -07:00

201 lines
6.4 KiB
TypeScript

'use server'
import { revalidatePath } from 'next/cache'
import { createClient } from '@/lib/supabase/server'
import { requireMember, requireMemberWithRole, parseInput } from '@/lib/auth-helpers'
import {
createForumThreadSchema,
updateForumThreadSchema,
createCommentSchema,
updateCommentSchema,
uuidSchema,
} from '@/lib/validations'
export async function createForumThread(input: {
title: string
body?: string
category?: string
}) {
const v = parseInput(createForumThreadSchema, input)
if (!v.ok) return { error: v.error }
const supabase = await createClient()
const auth = await requireMember(supabase)
if (!auth.ok) return { error: auth.error }
const { member } = auth
const { data, error } = await supabase
.from('forum_threads')
.insert({
space_id: member.space_id,
author_id: member.id,
title: v.data.title,
body: v.data.body ?? null,
category: v.data.category ?? 'general',
})
.select('id')
.single()
if (error) return { error: error.message }
revalidatePath('/forum')
return { id: data.id }
}
export async function updateForumThread(threadId: string, updates: {
title?: string
body?: string | null
category?: string
pinned?: boolean
locked?: boolean
}) {
const idCheck = parseInput(uuidSchema, threadId)
if (!idCheck.ok) return { error: 'Invalid thread ID' }
const v = parseInput(updateForumThreadSchema, updates)
if (!v.ok) return { error: v.error }
const supabase = await createClient()
const auth = await requireMember(supabase)
if (!auth.ok) return { error: auth.error }
const { member } = auth
// Pinning/locking is moderator-only (admin/board). The RLS UPDATE policy
// additionally requires the actor to be the author or admin/board, so a
// non-author cannot edit a thread regardless of this guard.
const wantsMod = v.data.pinned !== undefined || v.data.locked !== undefined
if (wantsMod) {
const modAuth = await requireMemberWithRole(supabase, ['admin', 'board'], 'Admin or board access required')
if (!modAuth.ok) return { error: modAuth.error }
}
const patch: Record<string, unknown> = {}
if (v.data.title !== undefined) patch.title = v.data.title
if (v.data.body !== undefined) patch.body = v.data.body
if (v.data.category !== undefined) patch.category = v.data.category
if (v.data.pinned !== undefined) patch.pinned = v.data.pinned
if (v.data.locked !== undefined) patch.locked = v.data.locked
const { error } = await supabase.from('forum_threads').update(patch).eq('id', idCheck.data).eq('space_id', member.space_id)
if (error) return { error: error.message }
revalidatePath('/forum')
revalidatePath(`/forum/${idCheck.data}`)
return { success: true as const }
}
export async function deleteForumThread(threadId: string) {
const v = parseInput(uuidSchema, threadId)
if (!v.ok) return { error: 'Invalid thread ID' }
const supabase = await createClient()
const auth = await requireMember(supabase)
if (!auth.ok) return { error: auth.error }
const { member } = auth
// RLS DELETE allows the author or admin; non-authors get a row-not-found
// error which we translate to a clearer message.
const { error, count } = await supabase
.from('forum_threads')
.delete({ count: 'exact' })
.eq('id', v.data)
.eq('space_id', member.space_id)
if (error) return { error: error.message }
if (count === 0) return { error: 'Not allowed to delete this thread' }
revalidatePath('/forum')
return { success: true as const }
}
export async function addComment(input: {
entity_type: 'forum_thread' | 'proposal' | 'incident' | 'policy'
entity_id: string
body: string
parent_id?: string | null
}) {
const v = parseInput(createCommentSchema, input)
if (!v.ok) return { error: v.error }
const supabase = await createClient()
const auth = await requireMember(supabase)
if (!auth.ok) return { error: auth.error }
const { member } = auth
// Reject comments on locked forum threads up front.
if (v.data.entity_type === 'forum_thread') {
const { data: thread } = await supabase
.from('forum_threads')
.select('locked')
.eq('id', v.data.entity_id)
.single()
if (thread?.locked) return { error: 'Thread is locked' }
}
const { data, error } = await supabase
.from('comments')
.insert({
space_id: member.space_id,
entity_type: v.data.entity_type,
entity_id: v.data.entity_id,
author_id: member.id,
parent_id: v.data.parent_id ?? null,
body: v.data.body,
})
.select('id')
.single()
if (error) return { error: error.message }
if (v.data.entity_type === 'forum_thread') {
revalidatePath(`/forum/${v.data.entity_id}`)
} else if (v.data.entity_type === 'proposal') {
revalidatePath(`/proposals/${v.data.entity_id}`)
} else if (v.data.entity_type === 'incident') {
revalidatePath(`/incidents/${v.data.entity_id}`)
}
return { id: data.id }
}
export async function editComment(commentId: string, body: string) {
const idCheck = parseInput(uuidSchema, commentId)
if (!idCheck.ok) return { error: 'Invalid comment ID' }
const v = parseInput(updateCommentSchema, { body })
if (!v.ok) return { error: v.error }
const supabase = await createClient()
const auth = await requireMember(supabase)
if (!auth.ok) return { error: auth.error }
const { member } = auth
const { data, error } = await supabase
.from('comments')
.update({ body: v.data.body, edited_at: new Date().toISOString() })
.eq('id', idCheck.data)
.eq('space_id', member.space_id)
.select('entity_type, entity_id')
.single()
if (error) return { error: error.message }
if (data?.entity_type === 'forum_thread') revalidatePath(`/forum/${data.entity_id}`)
return { success: true as const }
}
export async function deleteComment(commentId: string) {
const v = parseInput(uuidSchema, commentId)
if (!v.ok) return { error: 'Invalid comment ID' }
const supabase = await createClient()
const auth = await requireMember(supabase)
if (!auth.ok) return { error: auth.error }
const { member } = auth
const { data, error } = await supabase
.from('comments')
.delete()
.eq('id', v.data)
.eq('space_id', member.space_id)
.select('entity_type, entity_id')
.single()
if (error) return { error: error.message }
if (data?.entity_type === 'forum_thread') revalidatePath(`/forum/${data.entity_id}`)
return { success: true as const }
}