types: clear remaining tsc errors across 41 files (76→14, behavior-preserving)

Per-file type-only fixes surfaced after the Supabase client was correctly
typed. All fixes preserve runtime behavior; no any/ts-ignore/ts-expect-error.

- lib/supabase/client.ts: annotate the browser client as SupabaseClient<Database>
  (same ssr/js drift as server.ts; fixes it centrally for all callers).
- Supabase embedded-select joins whose FK metadata is missing from the
  generated types are bridged with `as unknown as <target>` + a TODO to remove
  after regenerating types/database.ts.
- setState optimistic-update variance and raw <select> enum values cast to the
  precise element/union type; .insert payload fields (Json, enums) given the
  precise column type via satisfies/field casts.
- Added narrowing guards where a value was legitimately nullable (comms channel,
  public form page) without changing the intended path.

The 14 remaining errors are confined to the four files fixed in Phase B (real
bugs + the tautological actions.test rewrite). 639 tests still green.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This commit is contained in:
Moheeb Zara
2026-08-01 18:56:11 -07:00
co-authored by Claude Opus 4.8
parent 1766780bca
commit b1edb5c460
41 changed files with 148 additions and 59 deletions
+2
View File
@@ -21,6 +21,8 @@ export default async function SettingsPage() {
const { data: space } = await supabase
.from('spaces').select('*').eq('id', member.space_id).single()
if (!space) redirect('/dashboard')
const { data: integrations } = await supabase
.from('integrations').select('*').eq('space_id', member.space_id)
+1 -1
View File
@@ -194,7 +194,7 @@ export default function SettingsClient({ space, isAdmin, integrations, currentRo
const existing = integrations.find(i => i.platform === config.platform)
const initialForm: Record<string, string> = {}
config.fields.forEach(f => {
initialForm[f.key] = existing?.config?.[f.key] || ''
initialForm[f.key] = (existing?.config as Record<string, string> | undefined)?.[f.key] || ''
})
setIntegrationForm(initialForm)
setEditingIntegration(config)