From dd8962766fddcf20341a214181dfd28eabb43685 Mon Sep 17 00:00:00 2001 From: Daniel Han Date: Tue, 25 Aug 2026 19:09:47 +0000 Subject: [PATCH] tests: record what the qwen4exp arch-test skip actually observes The old note guessed that the hyper-connection keys never reach the file. They do: dumping the gguf_context handed to llama_model_init_from_user shows both among its 67 KVs, and the loader still reports one missing. --- tests/test-llama-archs.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/test-llama-archs.cpp b/tests/test-llama-archs.cpp index 3b8566fb14..0d455a45ca 100644 --- a/tests/test-llama-archs.cpp +++ b/tests/test-llama-archs.cpp @@ -493,9 +493,9 @@ static bool arch_supported(const llm_arch arch) { return false; // FIXME @ngxson } if (arch == LLM_ARCH_QWEN4EXP) { - // FIXME: get_gguf_ctx's hyper-connection keys never reach the synthesised - // file, so loading trips on hyper_connection.count. Graph is covered by - // the vLLM parity tests. + // FIXME: loading reports "key not found: qwen4exp.hyper_connection.count" even + // though the gguf_context passed in carries both HC keys among its 67 KVs, so + // the mismatch is in the loader's view of it. Graph is covered by vLLM parity. return false; } if (arch == LLM_ARCH_GRANITE_SWITCH) {