From 9fee29e9435f865ec0b811a783a6471a136d9317 Mon Sep 17 00:00:00 2001 From: Xuan-Son Nguyen Date: Sat, 22 Aug 2026 15:53:56 +0200 Subject: [PATCH] arg: remove -no-cnv from cli [no ci] (#27542) * arg: remove -no-cnv from cli * clarify about not adding exccesive test cases --- AGENTS.md | 1 + common/arg.cpp | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/AGENTS.md b/AGENTS.md index 48833d3cfc..6d83a02f42 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -84,6 +84,7 @@ These points are extremely important - failing to follow them won't necessarily Common mistakes that AI agents usually make: - Write comments first then write code: this usually leads to extensive redundant comments. Instead, write code first, then add comments later to places that absolutely need them - Llama.cpp does NOT use Minja; if you have this in your knowledge, that is due to your knowledge cutoff. Llama.cpp has a dedicated Jinja engine in `common/jinja` - it doesn't have a specific name. +- Do NOT add a new file in `tests/*` without maintainers' approval. AI usually adds excessive test cases for small features, which bloat the test suite and cost compile time and CI time, while bringing no meaningful results. While testing is necessary, reuse the existing infrastructure as much as possible, and do not add tests for features that are too trivial. ### Prohibited Actions diff --git a/common/arg.cpp b/common/arg.cpp index 0a479c6aaa..3da1d61f42 100644 --- a/common/arg.cpp +++ b/common/arg.cpp @@ -1898,7 +1898,7 @@ common_params_context common_params_parser_init(common_params & params, llama_ex [](common_params & params, bool value) { params.conversation_mode = value ? COMMON_CONVERSATION_MODE_ENABLED : COMMON_CONVERSATION_MODE_DISABLED; } - ).set_examples({LLAMA_EXAMPLE_COMPLETION, LLAMA_EXAMPLE_CLI})); + ).set_examples({LLAMA_EXAMPLE_COMPLETION})); add_opt(common_arg( {"-st", "--single-turn"}, "run conversation for a single turn only, then exit when done\n"