From c818d498a9db3bfddb32b5e185ffe614859066c7 Mon Sep 17 00:00:00 2001 From: SuperQ Date: Tue, 11 Mar 2025 18:47:49 +0100 Subject: [PATCH] Logging cleanup * Cleanup additional `fmt.Println()` that should call logger. * Use `%v` for logging errors. Signed-off-by: SuperQ --- block_device.go | 2 +- usb_mass_storage.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/block_device.go b/block_device.go index 5df008c..3a44135 100644 --- a/block_device.go +++ b/block_device.go @@ -142,7 +142,7 @@ func (d *NBDDevice) runClientConn() { ExportName: "jetkvm", BlockSize: uint32(4 * 1024), }) - logger.Infof("nbd client exited: %w", err) + logger.Infof("nbd client exited: %v", err) } func (d *NBDDevice) Close() { diff --git a/usb_mass_storage.go b/usb_mass_storage.go index 39e6dd9..1036f22 100644 --- a/usb_mass_storage.go +++ b/usb_mass_storage.go @@ -58,7 +58,7 @@ func setMassStorageMode(cdrom bool) error { } func onDiskMessage(msg webrtc.DataChannelMessage) { - fmt.Println("Disk Message, len:", len(msg.Data)) + logger.Infof("Disk Message, len: %d", len(msg.Data)) diskReadChan <- msg.Data } @@ -176,7 +176,7 @@ func rpcUnmountImage() error { defer virtualMediaStateMutex.Unlock() err := setMassStorageImage("\n") if err != nil { - fmt.Println("Remove Mass Storage Image Error", err) + logger.Warnf("Remove Mass Storage Image Error: %v", err) } //TODO: check if we still need it time.Sleep(500 * time.Millisecond)