From a9bb8d2894c3de64800cad542773b64e39efb09a Mon Sep 17 00:00:00 2001 From: Marc Brooks Date: Thu, 12 Jun 2025 21:49:26 -0500 Subject: [PATCH] chore/fix-usb-default - Fix the base usb configuration In reviewing the config.go settings for idProduct and bcdDevice are not formatted correctly. All examples on GitHub have 0x0104 and 0x0100 respectively. The idProduct value gets overwritten with valid values when you change the configuration (because they are correct in the options), but until you do the USB initialization will not be correct. --- internal/usbgadget/config.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/usbgadget/config.go b/internal/usbgadget/config.go index 1c4f9c3..6d1bd39 100644 --- a/internal/usbgadget/config.go +++ b/internal/usbgadget/config.go @@ -30,8 +30,8 @@ var defaultGadgetConfig = map[string]gadgetConfigItem{ attrs: gadgetAttributes{ "bcdUSB": "0x0200", // USB 2.0 "idVendor": "0x1d6b", // The Linux Foundation - "idProduct": "0104", // Multifunction Composite Gadget - "bcdDevice": "0100", + "idProduct": "0x0104", // Multifunction Composite Gadget + "bcdDevice": "0x0100", // USB2 }, configAttrs: gadgetAttributes{ "MaxPower": "250", // in unit of 2mA