From a805d00e2915c2c8a8d1726eb767c0f9406ed748 Mon Sep 17 00:00:00 2001
From: Adam Shiervani <adam.shiervani@gmail.com>
Date: Wed, 29 Oct 2025 16:11:07 +0100
Subject: [PATCH] fix: video quality  (#913)

---
 config.go                   | 32 +++++++++++++++++++++++++++++---
 internal/native/cgo/ctrl.c  |  6 +++---
 internal/native/cgo/video.c |  2 +-
 internal/native/native.go   |  2 +-
 jsonrpc.go                  |  9 +++++----
 5 files changed, 39 insertions(+), 12 deletions(-)

diff --git a/config.go b/config.go
index 080cfd47..786fe949 100644
--- a/config.go
+++ b/config.go
@@ -161,9 +161,35 @@ var defaultConfig = &Config{
 		RelativeMouse: true,
 		Keyboard:      true,
 		MassStorage:   true,
-	},
-	NetworkConfig:   &network.NetworkConfig{},
-	DefaultLogLevel: "INFO",
+	}
+)
+
+func getDefaultConfig() Config {
+	return Config{
+		CloudURL:             "https://api.jetkvm.com",
+		CloudAppURL:          "https://app.jetkvm.com",
+		AutoUpdateEnabled:    true, // Set a default value
+		ActiveExtension:      "",
+		KeyboardMacros:       []KeyboardMacro{},
+		DisplayRotation:      "270",
+		KeyboardLayout:       "en-US",
+		DisplayMaxBrightness: 64,
+		DisplayDimAfterSec:   120,  // 2 minutes
+		DisplayOffAfterSec:   1800, // 30 minutes
+		JigglerEnabled:       false,
+		// This is the "Standard" jiggler option in the UI
+		JigglerConfig: func() *JigglerConfig { c := defaultJigglerConfig; return &c }(),
+		TLSMode:       "",
+		UsbConfig:     func() *usbgadget.Config { c := defaultUsbConfig; return &c }(),
+		UsbDevices:    func() *usbgadget.Devices { c := defaultUsbDevices; return &c }(),
+		NetworkConfig: func() *types.NetworkConfig {
+			c := &types.NetworkConfig{}
+			_ = confparser.SetDefaultsAndValidate(c)
+			return c
+		}(),
+		DefaultLogLevel:    "INFO",
+		VideoQualityFactor: 1.0,
+	}
 }
 
 var (
diff --git a/internal/native/cgo/ctrl.c b/internal/native/cgo/ctrl.c
index 0c10ee15..547d5694 100644
--- a/internal/native/cgo/ctrl.c
+++ b/internal/native/cgo/ctrl.c
@@ -306,7 +306,7 @@ int jetkvm_ui_add_flag(const char *obj_name, const char *flag_name) {
     if (obj == NULL) {
         return -1;
     }
-    
+
     lv_obj_flag_t flag_val = str_to_lv_obj_flag(flag_name);
     if (flag_val == 0)
     {
@@ -368,7 +368,7 @@ void jetkvm_video_stop() {
 }
 
 int jetkvm_video_set_quality_factor(float quality_factor) {
-    if (quality_factor < 0 || quality_factor > 1) {
+    if (quality_factor <= 0 || quality_factor > 1) {
         return -1;
     }
     video_set_quality_factor(quality_factor);
@@ -417,4 +417,4 @@ void jetkvm_crash() {
     // let's call a function that will crash the program
     int* p = 0;
     *p = 0;
-}
\ No newline at end of file
+}
diff --git a/internal/native/cgo/video.c b/internal/native/cgo/video.c
index 917e9163..857acbbb 100644
--- a/internal/native/cgo/video.c
+++ b/internal/native/cgo/video.c
@@ -235,7 +235,7 @@ int video_init(float factor)
 {
     detect_sleep_mode();
 
-    if (factor < 0 || factor > 1) {
+    if (factor <= 0 || factor > 1) {
         factor = 1.0f;
     }
     quality_factor = factor;
diff --git a/internal/native/native.go b/internal/native/native.go
index 0a773246..cb8761cf 100644
--- a/internal/native/native.go
+++ b/internal/native/native.go
@@ -71,7 +71,7 @@ func NewNative(opts NativeOptions) *Native {
 	sleepModeSupported := isSleepModeSupported()
 
 	defaultQualityFactor := opts.DefaultQualityFactor
-	if defaultQualityFactor < 0 || defaultQualityFactor > 1 {
+	if defaultQualityFactor <= 0 || defaultQualityFactor > 1 {
 		defaultQualityFactor = 1.0
 	}
 
diff --git a/jsonrpc.go b/jsonrpc.go
index ea6c6fba..93944202 100644
--- a/jsonrpc.go
+++ b/jsonrpc.go
@@ -199,10 +199,8 @@ func rpcReboot(force bool) error {
 	return nil
 }
 
-var streamFactor = 1.0
-
 func rpcGetStreamQualityFactor() (float64, error) {
-	return streamFactor, nil
+	return config.VideoQualityFactor, nil
 }
 
 func rpcSetStreamQualityFactor(factor float64) error {
@@ -212,7 +210,10 @@ func rpcSetStreamQualityFactor(factor float64) error {
 		return err
 	}
 
-	streamFactor = factor
+	config.VideoQualityFactor = factor
+	if err := SaveConfig(); err != nil {
+		return fmt.Errorf("failed to save config: %w", err)
+	}
 	return nil
 }