From 951e673e0c45068ee718f90960b27f2031fafb67 Mon Sep 17 00:00:00 2001 From: Siyuan Miao Date: Fri, 11 Apr 2025 18:55:31 +0200 Subject: [PATCH] chore(ntp): add logging for time sync errors --- ntp.go | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/ntp.go b/ntp.go index 069143d..a104c56 100644 --- a/ntp.go +++ b/ntp.go @@ -132,8 +132,14 @@ func queryNetworkTime() (*time.Time, error) { Str("time", now.Format(time.RFC3339)). Msg("NTP server returned time") return now, nil + } else { + ntpLogger.Error(). + Str("ntp_server", server). + Str("error", err.Error()). + Msg("failed to query NTP server") } } + httpUrls := []string{ "http://apple.com", "http://cloudflare.com", @@ -146,10 +152,15 @@ func queryNetworkTime() (*time.Time, error) { Str("time", now.Format(time.RFC3339)). Msg("HTTP server returned time") return now, nil + } else { + ntpLogger.Error(). + Str("http_url", url). + Str("error", err.Error()). + Msg("failed to query HTTP server") } } - return nil, ErrorfL(ntpLogger, "failed to query network time", nil) + return nil, ErrorfL(ntpLogger, "failed to query network time, all NTP servers and HTTP servers failed", nil) } func queryNtpServer(server string, timeout time.Duration) (now *time.Time, err error) {