From 6fd978b3827c3d3174ee210661a6ff55fcf3e8fb Mon Sep 17 00:00:00 2001 From: tutman96 <11356668+tutman96@users.noreply.github.com> Date: Sun, 19 Jan 2025 23:12:24 +0000 Subject: [PATCH] Rename JSONRPCServer to JSONRPCRouter --- internal/jsonrpc/{rpc_server.go => router.go} | 18 ++++++++---------- jsonrpc.go | 4 ++-- webrtc.go | 2 +- 3 files changed, 11 insertions(+), 13 deletions(-) rename internal/jsonrpc/{rpc_server.go => router.go} (93%) diff --git a/internal/jsonrpc/rpc_server.go b/internal/jsonrpc/router.go similarity index 93% rename from internal/jsonrpc/rpc_server.go rename to internal/jsonrpc/router.go index 5f8e870..fda698b 100644 --- a/internal/jsonrpc/rpc_server.go +++ b/internal/jsonrpc/router.go @@ -12,7 +12,7 @@ import ( "time" ) -type JSONRPCServer struct { +type JSONRPCRouter struct { writer io.Writer handlers map[string]*RPCHandler @@ -22,16 +22,14 @@ type JSONRPCServer struct { responseChannels map[int64]chan JSONRPCResponse } -func NewJSONRPCServer(writer io.Writer, handlers map[string]*RPCHandler) *JSONRPCServer { - return &JSONRPCServer{ - writer: writer, - handlers: handlers, - responseChannels: make(map[int64]chan JSONRPCResponse), - nextId: atomic.Int64{}, +func NewJSONRPCRouter(writer io.Writer, handlers map[string]*RPCHandler) *JSONRPCRouter { + return &JSONRPCRouter{ + writer: writer, + handlers: handlers, } } -func (s *JSONRPCServer) Request(method string, params map[string]interface{}, result interface{}) *JSONRPCResponseError { +func (s *JSONRPCRouter) Request(method string, params map[string]interface{}, result interface{}) *JSONRPCResponseError { id := s.nextId.Add(1) request := JSONRPCRequest{ JSONRPC: "2.0", @@ -108,7 +106,7 @@ type JSONRPCMessage struct { ID *int64 `json:"id,omitempty"` } -func (s *JSONRPCServer) HandleMessage(data []byte) error { +func (s *JSONRPCRouter) HandleMessage(data []byte) error { // Data will either be a JSONRPCRequest or JSONRPCResponse object // We need to determine which one it is var raw JSONRPCMessage @@ -193,7 +191,7 @@ func (s *JSONRPCServer) HandleMessage(data []byte) error { return s.writeResponse(response) } -func (s *JSONRPCServer) writeResponse(response JSONRPCResponse) error { +func (s *JSONRPCRouter) writeResponse(response JSONRPCResponse) error { responseBytes, err := json.Marshal(response) if err != nil { return err diff --git a/jsonrpc.go b/jsonrpc.go index 55df308..a80439d 100644 --- a/jsonrpc.go +++ b/jsonrpc.go @@ -34,8 +34,8 @@ func (w *DataChannelWriter) Write(data []byte) (int, error) { return len(data), nil } -func NewDataChannelJsonRpcServer(dataChannel *webrtc.DataChannel) *jsonrpc.JSONRPCServer { - return jsonrpc.NewJSONRPCServer( +func NewDataChannelJsonRpcRouter(dataChannel *webrtc.DataChannel) *jsonrpc.JSONRPCRouter { + return jsonrpc.NewJSONRPCRouter( NewDataChannelWriter(dataChannel), rpcHandlers, ) diff --git a/webrtc.go b/webrtc.go index 8f070a8..49a7b41 100644 --- a/webrtc.go +++ b/webrtc.go @@ -75,7 +75,7 @@ func newSession() (*Session, error) { switch d.Label() { case "rpc": session.RPCChannel = d - rpcServer := NewDataChannelJsonRpcServer(d) + rpcServer := NewDataChannelJsonRpcRouter(d) d.OnMessage(func(msg webrtc.DataChannelMessage) { go rpcServer.HandleMessage(msg.Data) })