From 1147c2a748416653175e5a6a39089c7c98d31d7b Mon Sep 17 00:00:00 2001 From: Adam Shiervani Date: Wed, 19 Feb 2025 13:36:35 +0100 Subject: [PATCH] fix(ui): correct event handler naming in WebRTCVideo component --- ui/src/components/WebRTCVideo.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ui/src/components/WebRTCVideo.tsx b/ui/src/components/WebRTCVideo.tsx index 7201130..7eaab50 100644 --- a/ui/src/components/WebRTCVideo.tsx +++ b/ui/src/components/WebRTCVideo.tsx @@ -331,7 +331,7 @@ export default function WebRTCVideo() { [keyDownHandler, keyUpHandler, resetKeyboardState, sendKeyboardEvent], ); - const videoKeyDownHandler = useCallback((e: KeyboardEvent) => { + const videoKeyUpHandler = useCallback((e: KeyboardEvent) => { // In fullscreen mode in chrome & safari, the space key is used to pause/play the video // there is no way to prevent this, so we need to simply force play the video when it's paused. // Fix only works in chrome based browsers. @@ -354,7 +354,7 @@ export default function WebRTCVideo() { videoElmRefValue.addEventListener("mousemove", mouseMoveHandler, { signal }); videoElmRefValue.addEventListener("pointerdown", mouseMoveHandler, { signal }); videoElmRefValue.addEventListener("pointerup", mouseMoveHandler, { signal }); - videoElmRefValue.addEventListener("keyup", videoKeyDownHandler, { signal }); + videoElmRefValue.addEventListener("keyup", videoKeyUpHandler, { signal }); videoElmRefValue.addEventListener("wheel", mouseWheelHandler, { signal }); videoElmRefValue.addEventListener( "contextmenu", @@ -376,7 +376,7 @@ export default function WebRTCVideo() { resetMousePosition, onVideoPlaying, mouseWheelHandler, - videoKeyDownHandler, + videoKeyUpHandler, ], );